Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie: refactor lock class #3109

Merged
merged 3 commits into from
Oct 22, 2023
Merged

trie: refactor lock class #3109

merged 3 commits into from
Oct 22, 2023

Conversation

gabrocheleau
Copy link
Contributor

This PR refactors the trie package to use the Lock class from util instead of the duplicated one in the trie package.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #3109 (10847d8) into master (a8ac9bb) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 10847d8 differs from pull request most recent head 9509f8b. Consider uploading reports for the commit 9509f8b to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client 87.68% <ø> (-0.04%) ⬇️
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.87% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 90.30% <ø> (ø)
trie 90.08% <100.00%> (-0.32%) ⬇️
tx 96.36% <ø> (ø)
util 86.97% <ø> (ø)
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gabrocheleau gabrocheleau merged commit d282e2e into master Oct 22, 2023
@holgerd77 holgerd77 deleted the trie/refactor-lock branch July 11, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants