-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snap Sync Fetchers: Highest-Known-Hash Optimization #2941
Merged
+95
−3
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7bf3148
Add assert to check if account trie root matches expected
scorbajio d026655
Use hashed tries
scorbajio 573bbe4
Skip tasks with limit lower than the highest known account key hash
scorbajio 7416e39
Remove log statements
scorbajio d788283
Merge branch 'master' of github.com:ethereumjs/ethereumjs-monorepo in…
scorbajio 5aaa968
Update test
scorbajio 5df820b
Use a object that is different from null object for termination check
scorbajio 8b41edc
Add tests for highestKnownHash optimization for account fetcher
scorbajio 9555f90
Merge branch 'master' of github.com:ethereumjs/ethereumjs-monorepo in…
scorbajio 64d9c9a
Revert "Use hashed tries"
scorbajio 31690c7
Merge branch 'master' into snap-tests-and-highest-hash-optimization
g11tech File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use a object that is different from null object for termination check
commit 5df820b3978daffd4dded82c1b0b7afb5d3a3946
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh so this solves the problem that if some range is empty it won't be requested 👍