client: improve new payload and fcu block executions #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
force-pushed
the
fix-findparents-engine
branch
from
fa4ec69 to
a43e389
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
force-pushed
the
fix-findparents-engine
branch
from
9fddecb to
862cb75
Compare
g11tech
force-pushed
the
fix-findparents-engine
branch
from
6b4ed8f to
7c8b858
Compare
g11tech
force-pushed
the
fix-findparents-engine
branch
from
542904c to
91f2f2f
Compare
g11tech
commented
Jul 14, 2023
|
|
||
| const result = await this.vm.runBlock({ clearCache, ...opts }) |
There was a problem hiding this comment.
the diff here and below is because of the putting the code inside try catch
g11tech
commented
Jul 14, 2023
| @@ -271,168 +279,170 @@ export class VMExecution extends Execution { | |||
| if (this.running || !this.started || this.config.shutdown) return 0 | |||
| this.running = true | |||
|
|
|||
| // run inside a lock so as to not be entangle with runWithoutSetHead or setHead | |||
| return this.runWithLock<number>(async () => { | |||
There was a problem hiding this comment.
the diff here is because of the try catch added so that this.running can be turned to false in the finally section
|
Wanted to review, is this ready? 🙂 |
|
(and could we merge on positive review?) |
holgerd77
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix and optimize the block execution for engine's new payload and fcUs, supersedes #2787
vmHeadinstead of the actualvmheadexecutedBlocks)vmHeadhash should have been used as its used to find parents tillvmHeadexecutedBlocksmap in engine for easy figuring out what has been executed (rather than checkingstateRootin state manager because a bad block can be formed with previously executedstateRootwhich would of course be declared valid) ,executedBlocksandremoteBlocksbased onfinalizedandvmheadVmExecutions already busy - and return optimisticSYNCINGresponse which would be resolved later to valids or invalidsrunningflag is switched to false even ifrun(..)ofVmExecutionfailsA branch of this (devnet 7 compatible) seems to be working fine on devnet-7