Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Fixes for block and blob building uncovered in devnet6 #2763

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jun 8, 2023

Couple of issues discovered for block and blob building in devnet6:

  • excessDataGas was always being set to 0
  • blobs were not included for a blob tx causing versionedhash , to blobs mismatch

This PR fixes the same

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #2763 (9b2af62) into master (06fb9a6) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 91.08% <ø> (ø)
blockchain 90.72% <ø> (ø)
client 87.24% <100.00%> (-0.01%) ⬇️
common 97.00% <ø> (ø)
devp2p 89.43% <ø> (-0.05%) ⬇️
ethash ∅ <ø> (∅)
evm 79.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 86.28% <ø> (ø)
trie 89.92% <ø> (ø)
tx 95.69% <ø> (ø)
util 81.13% <ø> (ø)
vm 83.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@g11tech g11tech added PR state: merge ready package: client target: master Work to be done towards master branch labels Jun 8, 2023
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 50fe021 into master Jun 8, 2023
@holgerd77 holgerd77 deleted the fix-blockblob-building branch June 8, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants