-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libp2p
transport layer
#2758
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
/** | ||
* @module util | ||
*/ | ||
import { bytesToPrefixedHexString } from '@ethereumjs/util' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can use client's src util, it has browser handling, no reason to duplicate i think
To test this and verify the browser client works, do:
ethereumjs.run({
network: 'goerli',
syncmode: 'none',
}) You should see the client start up with some logs that look like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Nice separation work! 🙂 |
Libp2p
is a big chunk of ourclient
specific dependency tree and it's not used at the moment since we aren't currently continuing to develop thedevp2p
overlibp2p
code base (which was needed to allow our browser client to connect to nodejs clients). This PR removes that entire dependency tree (clears 200+ dependencies) and clears a number of potential risk vectors due to very outdated dependencies in that tree.libp2p
dependencies inclient