Fix logic bug in txPool.validate #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
force-pushed
the
txPook-logic-bug
branch
from
467334e to
1aa30e5
Compare
|
Fixed the other broken client test here. Should be ready for final review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a logic bug in the
txPool.validatefunction where we are retrieving an account balance from the wrong vm and stateManager instance. This caused an issue wheretxPool.validatewould fail when submitting a transaction via the RPCeth_sendRawTransactionendpoint after restarting the client on an existing stateDB where no transactions/blocks were being run.setStateRootwas being called on thevmCopybut the account balance was being retrieved from thevm.stateManagerwhich had an unknown stateroot and the account might not have the correct balance.