-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Miscellaneous tx related fixes for eth methods #2411
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
This looks good as far as it goes. I've spent the last hour trying to figure out how to run a test for a london block without success, but it would be good to add those tests to verify things work right for Typed Transactions. Will try to work on it some more and see if I can't get one that's valid. |
Have re-labelled to "WIP" to reflect the latest comment, @acolytec3 please switch back to "Ready for review/merge" or something when you are done with the tests. |
Finally got my new tests working. We'll see if this makes code coverage happy and will merge if so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now that coverage is up!
some eth tx method fixes extracted from shandong