Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: use a default chain name in fromGethGenesis if no chain name specified #2319

Merged
merged 4 commits into from
Sep 29, 2022
Merged

common: use a default chain name in fromGethGenesis if no chain name specified #2319

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e9a5df
common: make chain name mandatory in fromGethGenesis
g11tech Sep 28, 2022
fe51cb3
improve comment
g11tech Sep 28, 2022
271db5c
change startegy to just pass name custom
g11tech Sep 28, 2022
a2c0f3d
undo comment
g11tech Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/common/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ export class Common extends EventEmitter {
/**
* Static method to load and set common from a geth genesis json
* @param genesisJson json of geth configuration
* @param { chain, genesisHash, hardfork } to futher configure the common instance
* @param { chain, genesisHash, hardfork } to futher configure the common instance, mandatory option: `chain` representing custom chain name`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is no longer relevant.

* @returns Common
*/
static fromGethGenesis(
Expand All @@ -166,7 +166,7 @@ export class Common extends EventEmitter {
): Common {
const genesisParams = parseGethGenesis(genesisJson, chain)
const common = new Common({
chain: genesisParams.name,
chain: genesisParams.name ?? 'custom',
customChains: [genesisParams],
hardfork,
})
Expand Down