Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename Semaphore to Lock #2234

Merged
merged 1 commit into from
Aug 25, 2022
Merged

chore: rename Semaphore to Lock #2234

merged 1 commit into from
Aug 25, 2022

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 25, 2022 •
edited
Loading

A semaphore with a single permit is called a lock.

@faustbrian faustbrian marked this pull request as ready for review August 25, 2022 08:48
@codecov
Copy link

codecov bot commented Aug 25, 2022 •
edited
Loading

Codecov Report

Merging #2234 (e82ddaf) into master (e82ddaf) will not change coverage.
The diff coverage is n/a.

❗ Current head e82ddaf differs from pull request most recent head 542000f. Consider uploading reports for the commit 542000f to get more accurate results

Impacted file tree graph

Flag Coverage Δ
block 92.98% <0.00%> (ø)
blockchain 88.43% <0.00%> (ø)
client 87.00% <0.00%> (ø)
common 98.09% <0.00%> (ø)
devp2p 92.11% <0.00%> (ø)
ethash ∅ <0.00%> (∅)
evm 79.08% <0.00%> (ø)
rlp ∅ <0.00%> (∅)
statemanager 88.16% <0.00%> (ø)
trie 89.48% <0.00%> (ø)
tx 97.98% <0.00%> (ø)
util 92.33% <0.00%> (ø)
vm 85.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Rebased this via UI.

holgerd77
holgerd77 approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit 193e9e9 into master Aug 25, 2022
@holgerd77 holgerd77 deleted the semaphore-to-lock branch August 25, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: blockchain package: mpt PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faustbrian @holgerd77