Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(trie): replace get/set for key/value for nodes with function #2220

Merged
merged 36 commits into from
Aug 24, 2022
Merged

refactor(trie): replace get/set for key/value for nodes with function #2220

merged 36 commits into from
Aug 24, 2022

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 24, 2022 •
edited
Loading

Leaving as draft until #2215 is merged

Same as #2218 to avoid black magic and improve DX. This together with #2219 and #2218 would be my last pet peeve about the trie package 😅

holgerd77 and others added 30 commits August 23, 2022 12:32
@holgerd77
trie: removed deprecated prove() function (renamed to createProof())
fe64bd1
@holgerd77
trie: added secure option to base trie, integrated secure trie functi…
ddadf76 
…onality
@holgerd77
trie: adopted secureTrie.spec.ts tests (5 failing)
aa731fb
@holgerd77
trie: fixed copy function
3a511d8
@holgerd77
trie: fixed secureTrie.spec.ts branching test
ce77025
@holgerd77
trie: additional test fixes
5cb020a
@holgerd77
trie: removed secure.ts SecureTrie class definition file
80156ec
@holgerd77
trie: updated README
31f89cb
@holgerd77
trie: removed secure export, unified prepareTrieOpts and expand to Ch…
f090a80 
…eckpointTrie
@faustbrian
chore: wip
93dc08e 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
19f06dd 
Signed-off-by: Brian Faust <[email protected]>
@holgerd77
trie: renamed _secure -> _hashKeys and _hash() -> _hashKeysFunction
3042ff7
@faustbrian
refactor(trie): rename secure to useHashedKeys
789607e
@faustbrian
Merge branch 'refactore-secure-trie-as-an-option' into trie-checkpoin…
7add314 
…t-option
@faustbrian
chore: wip
f8e2572 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
a2ccd7c 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
132fa1f 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
Merge branch 'refactore-secure-trie-as-an-option' into trie-checkpoin…
a793952 
…t-option
@faustbrian
chore: wip
1dfc5b4 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
94021ed 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
925469b
@faustbrian
chore: wip
4ec3364 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
Merge branch 'refactore-secure-trie-as-an-option' into trie-checkpoin…
b014f34 
…t-option
@faustbrian
refactor(trie): rename secure to useHashedKeys
a50c89c
@faustbrian
Merge branch 'refactore-secure-trie-as-an-option' into trie-checkpoin…
2388783 
…t-option
@faustbrian
chore: wip
906f600 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
refactor(trie): always use CheckpointDB as internal database
29a5445
@faustbrian
chore: wip
f45b020 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
chore: wip
7ceff28 
Signed-off-by: Brian Faust <[email protected]>
@faustbrian
Merge branch 'unify-db' into trie-checkpoint-option
953b819
@codecov
Copy link

codecov bot commented Aug 24, 2022 •
edited
Loading

Codecov Report

Merging #2220 (041cd3a) into master (fffe4ab) will increase coverage by 2.52%.
The diff coverage is 92.92%.

❗ Current head 041cd3a differs from pull request most recent head 25543dd. Consider uploading reports for the commit 25543dd to get more accurate results

Impacted file tree graph

Flag Coverage Δ
block 92.98% <ø> (ø)
blockchain 88.88% <ø> (?)
client ?
common 59.55% <ø> (ø)
devp2p 92.25% <ø> (-0.09%) ⬇️
ethash ?
evm ?
rlp ∅ <ø> (∅)
statemanager 88.15% <ø> (ø)
trie 89.63% <92.92%> (-0.32%) ⬇️
tx 97.98% <ø> (ø)
util ?
vm 85.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from trie-checkpoint-option to master August 24, 2022 09:46
@faustbrian
Copy link
Contributor Author

@holgerd77 conflicts resolved

@faustbrian faustbrian marked this pull request as ready for review August 24, 2022 10:08
@faustbrian faustbrian requested a review from holgerd77 August 24, 2022 10:27
holgerd77
holgerd77 reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be ok with this as well (no approval yet).

@faustbrian faustbrian changed the base branch from master to big-messy-bunch August 24, 2022 11:44
@faustbrian faustbrian merged commit 5896a61 into big-messy-bunch Aug 24, 2022
@faustbrian faustbrian deleted the combine-node-classes branch August 24, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 left review comments

Assignees
No one assigned
Labels
package: mpt PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faustbrian @holgerd77