Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous fixes/improvements for evm, client, consensus and crypto #2040

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Jul 14, 2022

Various fixes and improvements to enable ethereumjs sync sepolia
WIP

  • fix evm precompile loading on hardfork change
  • make saveReceipts true by default and add a warning if interop with CL expected
  • integrate the new EC lib with msgHash fix allowing 0
  • fix the runBlock pre-merge block validation once blockchain crosses TTD
    - [ ] Replace kiln sync instructions with sepolia sync instructions separate PR to tackle this

@g11tech g11tech added PR state: WIP target: master Work to be done towards master branch labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #2040 (bf25d9b) into master (a60b878) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

Flag Coverage Δ
block 84.01% <ø> (ø)
blockchain 80.10% <ø> (ø)
client 78.37% <66.66%> (ø)
common 94.90% <ø> (ø)
devp2p 82.35% <ø> (-0.27%) ⬇️
ethash 90.81% <ø> (ø)
evm 40.85% <100.00%> (+0.02%) ⬆️
statemanager 84.55% <ø> (ø)
trie 73.79% <ø> (ø)
tx 92.18% <ø> (ø)
util 87.19% <ø> (ø)
vm 78.66% <50.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@paulmillr
Copy link
Member

@g11tech the library can be updated now, just pushed the release

@g11tech
Copy link
Contributor Author

g11tech commented Jul 14, 2022

near merge block execution looks fixed 👍 :

[07-14|20:59:58] INFO Executed blocks count=49 first=1450354 hash=0x5e6d…f19c td=16999208883641332 baseFee=7 hardfork=london last=1450403 hash=0xe35b…6ad6 txs=40 
[07-14|20:59:58] INFO Merge hardfork reached 🐼 👉 👈 🐼 ! block=1450408 td=17000018015853232 
[07-14|20:59:58] INFO First block for CL-framed execution: block=1450409 
[07-14|20:59:58] INFO Merge hardfork reached, stopping block fetcher
[07-14|20:59:58] INFO Imported blocks count=6 first=1450403 last=1450408 hash=0xe35b…6ad6 baseFee=7 hardfork=merge peers=25 
[07-14|20:59:58] INFO Executed blocks count=5 first=1450403 hash=0xe35b…6ad6 td=17000018015853232 baseFee=7 hardfork=london last=1450408 hash=0xd07c…7bc1 txs=0 

@g11tech g11tech marked this pull request as ready for review July 14, 2022 21:18
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, will directly merge! 🙂

On desk for the next three hours, will write the release notes and general release PR now.

logger?.warn(
`Starting client without --saveReceipts might lead to interop issues with a CL especially if the CL intends to propose blocks, omitting methods=${saveReceiptsMethods}`
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants