Fix consensus validation bugs #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix the client integration test failures that have been occurring lately |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
g11tech
approved these changes
Jul 9, 2022
|
Label, label, label, label 🤪...I will miss this in the release notes otherwise! Thanks a lot for adressing otherwise! 🙏 🙂 |
holgerd77
added
type: bug
PR state: needs review
package: block
package: client
target: master
🤦 Ugh, sorry! |
You are not alone! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs related to consensus validation that were introduced when we merged #1959
extraDatain genesis parameters forclientdevnet start-up_consensusFormatValidationinblockconstructor so thatextraDatacan be correctly constructed for PoA blocks.