Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evm refactor updates #1977

Merged
merged 13 commits into from
Jun 23, 2022
Merged

Evm refactor updates #1977

merged 13 commits into from
Jun 23, 2022

Conversation

jochem-brouwer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #1977 (e16dacd) into master (74d5937) will decrease coverage by 0.95%.
The diff coverage is 91.17%.

Impacted file tree graph

Flag Coverage Δ
block 84.30% <ø> (ø)
blockchain 81.03% <ø> (ø)
client 78.34% <ø> (ø)
common 95.01% <ø> (ø)
devp2p ?
ethash 90.81% <ø> (ø)
evm 40.28% <92.30%> (-2.34%) ⬇️
statemanager 84.55% <ø> (ø)
trie 73.72% <ø> (ø)
tx 92.17% <ø> (ø)
util 87.03% <ø> (ø)
vm 79.09% <87.50%> (+2.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

This looks already pretty good and tests are passing, might this be ready?

@holgerd77 holgerd77 marked this pull request as ready for review June 23, 2022 08:31
@holgerd77 holgerd77 force-pushed the evm-refactor-updates branch from 070786b to e16dacd Compare June 23, 2022 08:51
@holgerd77
Copy link
Member

Rebased this after local test rebase.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge, devp2p test failure likely just a timing issue (occurs occasionally on these kind of tests).

@holgerd77 holgerd77 merged commit 859087d into master Jun 23, 2022
@holgerd77 holgerd77 deleted the evm-refactor-updates branch June 23, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants