Client: Fcu handles if headBlockHash is an old block #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
cbrzn
commented
Mar 28, 2022
| @@ -141,7 +141,7 @@ tape(`${method}: call with valid fork choice state without payload attributes`, | |||
| const req = params(method, [validForkChoiceState]) | |||
| const expectRes = (res: any) => { | |||
| t.equal(res.body.result.payloadStatus.status, 'VALID') | |||
| t.equal(res.body.result.payloadStatus.latestValidHash, null) | |||
| t.equal(res.body.result.payloadStatus.latestValidHash, validForkChoiceState.headBlockHash) | |||
There was a problem hiding this comment.
This has been changed because I noticed that when fcu returns VALID it also returns the latestValidHash (Point 7 of specs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I aim to tackle:
Latest block after reorgfrom the Hive tests. Which makes sure thatforkchoiceUpdatedmethod is able to reorg if a previous block was sent asheadBlockHash