Client: Validate finalized block hash on ForkchoiceUpdated #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
changed the title
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
ryanio
previously approved these changes
Mar 21, 2022
cbrzn
force-pushed
the
engine/validate-finalized-block-hash
branch
from
afb0a10 to
7c7f94d
Compare
|
conflicts fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to validate that the finalized block exists in the chain. Fixing the test case from the Hive: Unknown SafeBlockHash
Implementation inspired from geth: https://github.com/ethereum/go-ethereum/blob/master/eth/catalyst/api.go#L154-L167
Also, this is bullet number 6 from fork choice update specs