-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: update status fields for EIPs and hardforks #1777
Conversation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
1012c34
to
b3bffed
Compare
packages/common/src/eips/2315.json
Outdated
@@ -3,7 +3,7 @@ | |||
"number": 2315, | |||
"comment": "Simple subroutines for the EVM", | |||
"url": "https://eips.ethereum.org/EIPS/eip-2315", | |||
"status": "Draft", | |||
"status": "EXPERIMENTAL", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no, this status here is really the EIP status. This EXPERIMENTAL
is only used in the VM to then indicate the status of the implementation.
I guess if we update here to EXPERIMENTAL
and mix this with the EIP states it get's chaotic. That said, this status
field is also only used internally, I added this when setting up the Common
class with the above semantics in mind. Not sure if it's very helpful and we generally want to keep or not.
We might want to discuss separately. In doubt we just repeat redundant information here, which will likely always get outdated again and again. I guess if we decide we could even "just remove" without the fear of any breaking-change consequences.
Nevertheless: for now will update here back to Draft
to keep things consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But, to add some own opinion on that: I am currently also undecided (to remove or not), this might also be some useful helper on the status of EIPs we have implemented (otherwise one would likely not always look this up manually).
9adfb1f
to
6288c49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great, thanks! But moving 2315 to experimental in VM has not been addressed here (have reopened the issue). |
Closes #1773
Have only updated the "status" fields, the rest are prettier formats.
(I wonder if we should open a separate PR to format all of our JSON and markdown files in the monorepo at once, the command from root would be:
npx prettier "**/*.{json,md}" --write
)