Convert bn to bigint #1771

holgerd77 · 2022-03-09T11:00:51Z

Replaces #1744

Rebased by commit cherry-picking on top of latest develop rebase state from #1764.

Note that this is only the "dirty work" 😋 and there will likely be 1-2 glitches which still needs to be fixed.

We'll see along the test run.

block: finish header changes block: test updates block: test fixes Partial difficulty fixes

…ve when using skipBalance

holgerd77 · 2022-03-14T09:23:18Z

🎉 🎉 🎉

Is this ready to be merged? 🙂

acolytec3 · 2022-03-14T09:50:02Z

Barring any further review comments, I'd say yes. I've been running the client on mainnet using the BigInt pr and it seems to be running quite smoothly.

holgerd77

Crazy. Crazy. Crazy.

I guess I haven't seen such a PR in my entire EthereumJS time.

Thanks @acolytec3 @paulmillr and helping hands for this amazing work.

Will do a small addition (three methods accidentally reintroduced) and then merge in. 🎉

holgerd77 · 2022-03-14T11:41:52Z

packages/block/README.md

-    gasLimit: new BN(100),
-    gasUsed: new BN(60)
+    gasLimit: BigInt(100),
+    gasUsed: BigInt(60)


Total side note and no need to change but just wanted to mention: I guess we can very well encourage people to use the *n* notation in their own usage and use this in our examples as well (I know that this is likely due to some search-replace pattern just auto-replaced here).

holgerd77 · 2022-03-14T12:07:09Z

packages/common/src/index.ts

+      throw new Error(`No (supported) active hardfork found`)
+    }
+  }
+


These methods have been removed along the work on #1753, so this here would be an accidental re-introduction. 😋

Will eventually directly address after a review myself.

holgerd77 · 2022-03-14T12:20:26Z

packages/util/src/signature.ts

-  if (rBN.isZero() || rBN.gt(SECP256K1_N) || sBN.isZero() || sBN.gt(SECP256K1_N)) {
+  if (
+    rBigInt === BigInt(0) ||
+    rBigInt >= SECP256K1_ORDER ||


Is this switching from gt to >= correct here?

(same below)

Valid rule: 0 < r < order, same for s.

So the previous rule was incorrect, the new rule is good.

holgerd77

LGTM.

Will admin-merge, can't approve since I re-submitted myself, but technically not my PR + rebase has been implicitly reviewed by the continued work being done.

* util: use bigints. Expose new secp constants * common: use bigints * tx: use bigints * lint: fix util, tx, common * tx: fix isSigned * update comment block style to be picked up by vscode * remove doc typo (extra `) * tx: add isSigned() tests to base.spec.ts to iterate across txTypes * block: bn to bigint changes wip block: finish header changes block: test updates block: test fixes Partial difficulty fixes * block: fix homestead difficulty * block: fix >= Byzantium difficulty * BigInt conversion fixes * block: update st.ok to st.equals * Update readme to use bigints * ethash: bn to bigint * blockchain: wip bn to bigint changes * devp2p: bn to bigint * vm: wip remaining bn -> bigint * vm: more test fixes * fix runTx negative value args test, ensure balance does not go negative when using skipBalance * vm: lint:fix * re-add newline * Blockchain: small rebase fix * vm: Fix API tests * client: bn to bigint updates in source * client: various fixes * client: last fixes * client: integration test fixes * replace st.ok usage with st.equal * normalize st.equals to st.equal * update toType cases * nits, lint * fix vm benchmarks * client: fix fullEthereumService tests * touch ups, fix miner integration test * use prefix increment * client: fix full sync test * test fixes * Fix reorg logic bug * bnTo... function renaming and cleanup * Goodbye bn.js * reverse changelog changes * nits * remove more BN, more nits * turn off restrict-plus-operands and remove disable overrides (does not work properly) * more nits, update package-lock * fix build errors, re-add @types/bn.js for rlp v2 export to fix build (will be removed in subsequent PR for rlp) * replace miller-rabin (bn.js) with bigint-crypto-utils isProbablyPrime * more nits / fixes * Fix misplaced paren * Fix miner test * more nits * fix buffer to big int * set expectedTests back to >= comparison * last fixes * Removed re-introduced Common methods Co-authored-by: Paul Miller <[email protected]> Co-authored-by: Ryan Ghods <[email protected]> Co-authored-by: acolytec3 <[email protected]> Co-authored-by: Jochem Brouwer <[email protected]>

author acolytec3 <[email protected]> 1648139433 -0400 committer Gabriel Rocheleau <[email protected]> 1648407705 -0400 Revert process code changes Common: method deprecations (new) (#1698) * common: delete deprecated hardforkBlock method * common: adapt tests to use hardforkBlockBN * common: delete deprecated nextHardforkBlock method * common/tests: rename nextHardforkBlock() calls to nextHardforkBlockBN() * common: adapt tests to use BN.eqn(number) * common: delete deprecated networkId() method * common: delete tests for networkId() * common: delete deprecated chainId() method * common: delete tests for .chainId() * delete deprecated forCustomChain meethod * common: delete forCustomChain() test * blockchain: switch forCustomChain to Common.custom * client: switch fromCustomChain to Common.custom * tx: switch forCustomChain to Common.custom * VM: switch forCustomChain to Common.custom * common: internalize _getInitializedChains() method * common: delete deprecaed chains/index.ts file * client: switch to Common._getInitializedChains * common: remove genesisStates/index.ts * common: remove test for genesisStates Common: Rename *BN methods to non-BN names (#1709) * common: rename nextHardforkBlockBN() to nextHardforkBlock() * common/tests: rename nextHardforkBlockBN() to nextHardforkBlock() * client: rename common.nextHardforkBlockBN() to common.nextHardforkBlock() * devp2p: rename common.nextHardforkBlockBN() to common.nextHardforkBlock() * common: rename hardforkBlockBN() to hardforkBlock() * common/tests: rename common.hardforkBlockBN() to common.hardforkBlock() * block: rename common.hardforkBlockBN() to common.hardforkBlock() * client: rename common.hardforkBlockBN() to common.hardforkBlock() * blockchain: rename common.hardforkBlockBN() to common.hardforkBlock() * devp2p: rename common.hardforkBlockBN() to common.hardforkBlock() * vm: rename common.hardforkBlockBN() to common.hardforkBlock() * common: rename chainIdBN() to chainId() * common/tests: rename common.chainIdBN() to common.chainId() * client: rename common.chainIdBN() to common.chainId() * blockchain: rename common.chainIdBN() to common.chainId() * devp2p: rename common.chainIdBN() to common.chainId() * tx: rename common.chainIdBN() to common.chainId() * vm: rename common.chainIdBN() to common.chainId() * common: rename networkIdBN() to networkId() * common/test: rename common.networkIdBN() to common.networkId() * client: rename common.networkIdBN() to common.networkId() * block: rename common.networkIdBN() to common.networkId() VM: Replace BN.js with bigints, Util helpers (#1671) * Replace BN.js with bigints in VM * Fix byteLength computation in EXP handler * Fix toTwos helper * Compute TWO_POWE256 using math instead of hex * Update packages/util/src/constants.ts Co-authored-by: Ryan Ghods <[email protected]> * Remove unused variable * Fix exponent byte length calc * Fix exp overflow * Fix precompile bigint conversions * Fix more bigint conversions * Fix EXP opcode handler * Fix logic bug in signextend * vm/gas: fix EXTCODECOPY gas * vm/gas: fix sha256 gas * vm/gas: sha256 const -> let * vm: lint * vm/logic: fix sdiv/smod and fromTwos/toTwos * vm/logic: fix SIGNEXTEND * vm/logic: fix CALLDATALOAD padding * vm/logic: remove weird comment * Fix SAR opcode handler * Use bufferToBigInt in Push opcode handler * use bufferToBigInt everywhere * Fix missing bufferToBigInt import * Check for edge case in expmod * Ignore prettier * Update browser tsconfig to es2020 lib * Remove dup ES2020 targets * attempt to dedupe "target" and "lib" tsconfig values * Update karma config to target es2020 in parser * Various test fixes * Lint and BN fixes * Add bigint helpers to util * lint fixes * various bigint helper additions * Lint fixes * Fix bnToBigInt * Lint/test fixes * Switch Xn to BigInt(X) * lint * lint * More Xn to BigInt(X) moves Co-authored-by: Ryan Ghods <[email protected]> Co-authored-by: Jochem Brouwer <[email protected]> Co-authored-by: Jochem Brouwer <[email protected]> monorepo: develop rebase 2022-02-23 fixes Develop Rebase Fixes (2022-03-05) Convert bn to bigint (#1771) * util: use bigints. Expose new secp constants * common: use bigints * tx: use bigints * lint: fix util, tx, common * tx: fix isSigned * update comment block style to be picked up by vscode * remove doc typo (extra `) * tx: add isSigned() tests to base.spec.ts to iterate across txTypes * block: bn to bigint changes wip block: finish header changes block: test updates block: test fixes Partial difficulty fixes * block: fix homestead difficulty * block: fix >= Byzantium difficulty * BigInt conversion fixes * block: update st.ok to st.equals * Update readme to use bigints * ethash: bn to bigint * blockchain: wip bn to bigint changes * devp2p: bn to bigint * vm: wip remaining bn -> bigint * vm: more test fixes * fix runTx negative value args test, ensure balance does not go negative when using skipBalance * vm: lint:fix * re-add newline * Blockchain: small rebase fix * vm: Fix API tests * client: bn to bigint updates in source * client: various fixes * client: last fixes * client: integration test fixes * replace st.ok usage with st.equal * normalize st.equals to st.equal * update toType cases * nits, lint * fix vm benchmarks * client: fix fullEthereumService tests * touch ups, fix miner integration test * use prefix increment * client: fix full sync test * test fixes * Fix reorg logic bug * bnTo... function renaming and cleanup * Goodbye bn.js * reverse changelog changes * nits * remove more BN, more nits * turn off restrict-plus-operands and remove disable overrides (does not work properly) * more nits, update package-lock * fix build errors, re-add @types/bn.js for rlp v2 export to fix build (will be removed in subsequent PR for rlp) * replace miller-rabin (bn.js) with bigint-crypto-utils isProbablyPrime * more nits / fixes * Fix misplaced paren * Fix miner test * more nits * fix buffer to big int * set expectedTests back to >= comparison * last fixes * Removed re-introduced Common methods Co-authored-by: Paul Miller <[email protected]> Co-authored-by: Ryan Ghods <[email protected]> Co-authored-by: acolytec3 <[email protected]> Co-authored-by: Jochem Brouwer <[email protected]>

* util: use bigints. Expose new secp constants * common: use bigints * tx: use bigints * lint: fix util, tx, common * tx: fix isSigned * update comment block style to be picked up by vscode * remove doc typo (extra `) * tx: add isSigned() tests to base.spec.ts to iterate across txTypes * block: bn to bigint changes wip block: finish header changes block: test updates block: test fixes Partial difficulty fixes * block: fix homestead difficulty * block: fix >= Byzantium difficulty * BigInt conversion fixes * block: update st.ok to st.equals * Update readme to use bigints * ethash: bn to bigint * blockchain: wip bn to bigint changes * devp2p: bn to bigint * vm: wip remaining bn -> bigint * vm: more test fixes * fix runTx negative value args test, ensure balance does not go negative when using skipBalance * vm: lint:fix * re-add newline * Blockchain: small rebase fix * vm: Fix API tests * client: bn to bigint updates in source * client: various fixes * client: last fixes * client: integration test fixes * replace st.ok usage with st.equal * normalize st.equals to st.equal * update toType cases * nits, lint * fix vm benchmarks * client: fix fullEthereumService tests * touch ups, fix miner integration test * use prefix increment * client: fix full sync test * test fixes * Fix reorg logic bug * bnTo... function renaming and cleanup * Goodbye bn.js * reverse changelog changes * nits * remove more BN, more nits * turn off restrict-plus-operands and remove disable overrides (does not work properly) * more nits, update package-lock * fix build errors, re-add @types/bn.js for rlp v2 export to fix build (will be removed in subsequent PR for rlp) * replace miller-rabin (bn.js) with bigint-crypto-utils isProbablyPrime * more nits / fixes * Fix misplaced paren * Fix miner test * more nits * fix buffer to big int * set expectedTests back to >= comparison * last fixes * Removed re-introduced Common methods Co-authored-by: Paul Miller <[email protected]> Co-authored-by: Ryan Ghods <[email protected]> Co-authored-by: acolytec3 <[email protected]> Co-authored-by: Jochem Brouwer <[email protected]>

paulmillr and others added 22 commits March 9, 2022 11:29

util: use bigints. Expose new secp constants

5317512

common: use bigints

b32dc65

tx: use bigints

3efd3b0

lint: fix util, tx, common

c2ba36c

tx: fix isSigned

8f46591

update comment block style to be picked up by vscode

a4912aa

remove doc typo (extra `)

603e362

tx: add isSigned() tests to base.spec.ts to iterate across txTypes

5943bf9

block: bn to bigint changes wip

827b235

block: finish header changes block: test updates block: test fixes Partial difficulty fixes

block: fix homestead difficulty

de1b4ab

block: fix >= Byzantium difficulty

b4e7788

BigInt conversion fixes

9e2cad4

block: update st.ok to st.equals

f6f504e

Update readme to use bigints

3dd8eae

ethash: bn to bigint

d846ea2

blockchain: wip bn to bigint changes

dc04d98

devp2p: bn to bigint

b60be12

vm: wip remaining bn -> bigint

7b2bca8

vm: more test fixes

c570707

fix runTx negative value args test, ensure balance does not go negati…

8f36fd0

…ve when using skipBalance

vm: lint:fix

4385155

re-add newline

cb129e9

holgerd77 added type: refactor package: tx package: util target: develop labels Mar 9, 2022

holgerd77 mentioned this pull request Mar 9, 2022

Convert bn to bigint #1744

Closed

holgerd77 added package: block package: blockchain package: devp2p labels Mar 9, 2022

ryanio force-pushed the util-bigint-rebased-2022-03-09 branch from 849d692 to 6aa7089 Compare March 12, 2022 01:34

acolytec3 and others added 5 commits March 11, 2022 21:18

Fix misplaced paren

42cd088

Fix miner test

2396256

more nits

32da0de

fix buffer to big int

ec75d37

set expectedTests back to >= comparison

c865a1b

ryanio force-pushed the util-bigint-rebased-2022-03-09 branch from 4afe30c to c865a1b Compare March 12, 2022 03:57

last fixes

681b2af

ryanio force-pushed the util-bigint-rebased-2022-03-09 branch from 0b25c9c to 681b2af Compare March 12, 2022 07:25

gabrocheleau mentioned this pull request Mar 12, 2022

block: unify blockHeader constructor input shapes #1782

Closed

4 tasks

holgerd77 commented Mar 14, 2022

View reviewed changes

Removed re-introduced Common methods

cefadcf

holgerd77 commented Mar 14, 2022

View reviewed changes

holgerd77 merged commit 7454ec5 into develop Mar 14, 2022

acolytec3 mentioned this pull request Mar 23, 2022

Deprecate util/object #1809

Merged

holgerd77 deleted the util-bigint-rebased-2022-03-09 branch June 30, 2022 12:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert bn to bigint #1771

Convert bn to bigint #1771

holgerd77 commented Mar 9, 2022

holgerd77 commented Mar 14, 2022

acolytec3 commented Mar 14, 2022

holgerd77 left a comment

holgerd77 Mar 14, 2022

holgerd77 Mar 14, 2022

holgerd77 Mar 14, 2022

paulmillr Mar 14, 2022

holgerd77 left a comment

Convert bn to bigint #1771

Convert bn to bigint #1771

Conversation

holgerd77 commented Mar 9, 2022

holgerd77 commented Mar 14, 2022

acolytec3 commented Mar 14, 2022

holgerd77 left a comment

Choose a reason for hiding this comment

holgerd77 Mar 14, 2022

Choose a reason for hiding this comment

holgerd77 Mar 14, 2022

Choose a reason for hiding this comment

holgerd77 Mar 14, 2022

Choose a reason for hiding this comment

paulmillr Mar 14, 2022

Choose a reason for hiding this comment

holgerd77 left a comment

Choose a reason for hiding this comment