Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx: Execute on deprecation notes #1742

Merged
merged 13 commits into from
Feb 24, 2022
Merged

Tx: Execute on deprecation notes #1742

merged 13 commits into from
Feb 24, 2022

Conversation

ScottyPoi
Copy link
Contributor

Fixes #1739

Remove deprecated method declarations and tests

  • get transactionType()
  • get senderR()
  • get senderS()
  • get yParity()
  • tx.fromRlpSerializedTx()
  • _unsignedTxImplementsEIP155()
  • _signedTxImplementsEIP155()
  • TransactionFactory.getTransactionClass()

@codecov
Copy link

codecov bot commented Feb 24, 2022 •
edited
Loading

Codecov Report

Merging #1742 (8c5d626) into develop (ee973cf) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 85.89% <ø> (ø)
blockchain 83.55% <ø> (ø)
client 73.57% <ø> (ø)
common 93.40% <ø> (ø)
devp2p 82.76% <ø> (-0.27%) ⬇️
ethash 90.76% <ø> (ø)
trie 86.53% <ø> (ø)
tx 93.53% <100.00%> (+2.56%) ⬆️
util 89.91% <ø> (ø)
vm 81.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to complain about 😋, thanks for tackling this so quickly.

Cool, will merge.

@holgerd77 holgerd77 changed the title Tx-execute-on-deprecation-notes Tx: Execute on deprecation notes Feb 24, 2022
@holgerd77 holgerd77 merged commit 394fa06 into develop Feb 24, 2022
@holgerd77 holgerd77 deleted the tx-execute-on-deprecation-notes branch February 24, 2022 17:41
holgerd77 pushed a commit that referenced this pull request Mar 5, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
b7b729b 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
holgerd77 pushed a commit that referenced this pull request Mar 24, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
0d4d82d 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
holgerd77 pushed a commit that referenced this pull request Apr 5, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
b45b146 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
holgerd77 pushed a commit that referenced this pull request Apr 7, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
eab686d 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
g11tech pushed a commit that referenced this pull request Apr 29, 2022
@ScottyPoi @g11tech
Tx: Execute on deprecation notes (#1742)
278e13c 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
holgerd77 pushed a commit that referenced this pull request May 4, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
6699974 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
g11tech pushed a commit that referenced this pull request Jun 2, 2022
@ScottyPoi @g11tech
Tx: Execute on deprecation notes (#1742)
979b479 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
g11tech pushed a commit that referenced this pull request Jun 2, 2022
@ScottyPoi @g11tech
Tx: Execute on deprecation notes (#1742)
98d82f2 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
g11tech pushed a commit that referenced this pull request Jun 2, 2022
@ScottyPoi @g11tech
Tx: Execute on deprecation notes (#1742)
f6b8a99 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
g11tech pushed a commit that referenced this pull request Jun 3, 2022
@ScottyPoi @g11tech
Tx: Execute on deprecation notes (#1742)
4ac43d0 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
holgerd77 pushed a commit that referenced this pull request Jun 8, 2022
@ScottyPoi @holgerd77
Tx: Execute on deprecation notes (#1742)
14e7b20 
* Tx: Remove baseTransaction.transactionType

* tx: remove get senderR()

* tx: remove test for senderR()

* tx: remove senderS()

* tx: remove test for senderS()

* tx: remove yParity / replace with v

* tx: remove test for yParity()

* Tx: remove fromRlpSerializedTx()

* Tx: remove test for fromRlpSerializedTx()

* Tx: remove _unsignedTxImplementsEIP155

* Tx: Remove _signedTxImplementsEIP155()

* Tx: Remove TransactionFactory.getTransactionClass

* Tx: Remove test for .getTransactionClass()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: tx PR state: WIP type: refactor type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottyPoi @holgerd77