Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add dev param to start devnet with miner #1492

Merged
merged 11 commits into from
Sep 28, 2021
Merged

client: add dev param to start devnet with miner #1492

merged 11 commits into from
Sep 28, 2021

Conversation

acolytec3
Copy link
Contributor

Adds a new cli param --dev that starts the client with a miner with a prefunded account

@codecov
Copy link

codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #1492 (5f57eee) into master (cf95e04) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

Flag Coverage Δ
block 86.71% <100.00%> (-0.19%) ⬇️
blockchain 82.85% <100.00%> (ø)
client 83.91% <ø> (-0.79%) ⬇️
common 94.08% <ø> (ø)
devp2p 82.92% <ø> (+0.02%) ⬆️
ethash 90.71% <ø> (ø)
tx 87.34% <ø> (-0.13%) ⬇️
vm 78.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3
Copy link
Contributor Author

Here's an initial version of the --dev CLI command. At the moment, it just starts up the miner with a generated account and preconfigured hardforks. Do y'all think it's worth adding a flow to allow you to specify the block numbers for the hardforks?

ryanio
ryanio reviewed Sep 24, 2021
View reviewed changes
packages/client/bin/cli.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Sep 24, 2021
View reviewed changes
packages/client/bin/cli.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Sep 24, 2021
View reviewed changes
packages/client/bin/cli.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Sep 24, 2021
View reviewed changes
packages/client/bin/cli.ts Outdated Show resolved Hide resolved
ryanio
ryanio reviewed Sep 24, 2021
View reviewed changes
packages/client/bin/cli.ts Outdated Show resolved Hide resolved
@ryanio
fix setting london hardfork block to 0 or 1
926001a
@ryanio
prefer some more named imports
f165acf 
(also tried for 'path' and 'readline' but those were more readable in the actual code parts as their global import)
ryanio
ryanio approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for adding this param, so easy! i will be using this a lot.

@acolytec3 acolytec3 merged commit 5b86cc1 into master Sep 28, 2021
@acolytec3 acolytec3 deleted the cli-dev-command branch September 28, 2021 01:45
@holgerd77
Copy link
Member

Hi there,
that's pretty cool, so great! 🎉

I've got some questions, but I'll leave it for now. Please let's not do any further client work until the end of the week apart from bug fixing and making things more robust and resilient - so doing some kind of feature freeze here - so that we get well through the releases. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

@holgerd77 holgerd77 Awaiting requested review from holgerd77

Assignees
No one assigned
Labels
package: block package: blockchain package: client PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acolytec3 @holgerd77 @ryanio