Monorepo: Add src files to package build / VM lib -> src renaming #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock, blockchain, common, devp2p, ethash, trie, tx and util library
…ion build (package.json)
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ig already sets `src`)
holgerd77
commented
Jun 17, 2021
| 'lib/state/cache.ts', | ||
| 'src/bloom/*.ts', | ||
| 'src/evm/**', | ||
| 'src/state/cache.ts', |
There was a problem hiding this comment.
Ah, important catch, I really thought I had it. Thanks for having another closer look here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1287 by adding
srcfolders to thepackage.jsonfile of all packages except the client which still generally has got a somewhat differing build structure.This PR also does the
lib->srcrenaming for the VM package to align with the other packages. This has gotten a bit extensive 😋 , did my best to catch every occurrence.