Skip to content

Commit

Permalink
vm benchmarks: skip blocks reporting false positives for alert thresh…
Browse files Browse the repository at this point in the history
…old (#1546)

* increase vm benchmarks threshold from 200% to 270% to cover false positives

* add prettier.config.js to root, run on config and workflow files

* Revert "increase vm benchmarks threshold from 200% to 270% to cover false positives"

This reverts commit 1621ae5.

* skip blocks that frequently trip alert threshold
  • Loading branch information
ryanio authored Nov 3, 2021
1 parent ade4233 commit 5a0ab30
Show file tree
Hide file tree
Showing 19 changed files with 104 additions and 105 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/block-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/blockchain-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/client-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/common-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/devp2p-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e-hardhat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
tags: ['*']
pull_request:
types: [opened, reopened, synchronize]

env:
cwd: ${{github.workspace}}

Expand All @@ -26,7 +26,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ethash-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
19 changes: 9 additions & 10 deletions .github/workflows/node-versions.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
#
# This special file aims to run node tests for each relevant node version.
#
# This special file aims to run node tests for each relevant node version.
# A relevant node version can be: active, current, maintenance or EOL with some months of tolerance
# For more details, please check ./scripts/node-versions.js
#
#

name: Node versions
on:
schedule:
- cron: 0 0 * * *

jobs:
get-node-versions:
runs-on: ubuntu-latest
Expand All @@ -26,7 +26,7 @@ jobs:
needs: get-node-versions
runs-on: ubuntu-latest
strategy:
matrix:
matrix:
node: ${{ fromJson(needs.get-node-versions.outputs.matrix) }}
fail-fast: false
steps:
Expand All @@ -40,7 +40,7 @@ jobs:
node-version: ${{ matrix.node }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand All @@ -65,7 +65,7 @@ jobs:
run: npm run test
working-directory: packages/client
if: ${{ matrix.node >= 15 }}

- name: Test Devp2p
run: npm run test
working-directory: packages/devp2p
Expand All @@ -82,16 +82,15 @@ jobs:
- name: Test Trie
run: npm run test
working-directory: packages/trie

- name: Test Tx
run: npm run test
working-directory: packages/tx

- name: Test Util
run: npm run test
working-directory: packages/util

- name: Test VM
run: npm run test:API
working-directory: packages/vm

6 changes: 3 additions & 3 deletions .github/workflows/trie-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down Expand Up @@ -59,12 +59,12 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
working-directory: ${{github.workspace}}

- run: npm run benchmarks | tee output.txt
working-directory: ${{ env.cwd }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tx-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/util-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
node-version: ${{ matrix.node-version }}
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/vm-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
working-directory: ${{github.workspace}}

- run: npm run coverage

- uses: codecov/codecov-action@v1
with:
file: ${{ env.cwd }}/coverage/lcov.info
Expand All @@ -41,7 +41,7 @@ jobs:
- run: npm run test:API
- run: npm run test:API:browser
- run: npm run lint

test-vm-state:
runs-on: ubuntu-latest
steps:
Expand All @@ -55,7 +55,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand All @@ -76,7 +76,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand All @@ -97,7 +97,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

- run: npm i
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/vm-nightly-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

# The job is meant to run with a fresh lock file
Expand All @@ -51,7 +51,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

# The job is meant to run with a fresh lock file
Expand All @@ -77,7 +77,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

# The job is meant to run with a fresh lock file
Expand All @@ -104,7 +104,7 @@ jobs:
node-version: 12
cache: 'npm'

- name: Use npm v7 for workspaces support
- name: Use npm v7 for workspaces support
run: npm i -g npm@7

# The job is meant to run with a fresh lock file
Expand All @@ -114,5 +114,5 @@ jobs:

- run: npm i
working-directory: ${{github.workspace}}

- run: npm run test:state:slow
Loading

0 comments on commit 5a0ab30

Please sign in to comment.