Fix nits

ethereumjs · Sep 29, 2022 · 1cf6ed1 · 1cf6ed1 · github-actions · Sep 29, 2022
1 parent 55e0380
commit 1cf6ed1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/common/src/common.ts b/packages/common/src/common.ts
@@ -313,8 +313,9 @@ export class Common extends EventEmitter {
       // all hardforks apply, set hfIndex to the last one as thats the candidate
       hfIndex = hfs.length - 1
     } else if (hfIndex === 0) {
-      // Cant move back, ideally we should throw??
-      throw Error('No hardfork qualitifies')
+      // cannot have a case where a block number is before all applied hardforks
+      // since the chain has to start with a hardfork
+      throw Error('Must have at least one hardfork at block 0')
     } else {
       // The previous hardfork is the candidate here
       hfIndex = hfIndex - 1

diff --git a/packages/common/tests/hardforks.spec.ts b/packages/common/tests/hardforks.spec.ts
@@ -82,7 +82,7 @@ tape('[Common]: Hardfork logic', function (t: tape.Test) {
 
     try {
       c.getHardforkByBlockNumber(0)
-      t.fail('should have thrown since no hardfork should quality')
+      t.fail('should have thrown since no hardfork should qualify')
     } catch (e) {
       t.pass('throw since no hardfork qualifies')
     }