Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\hyperlink{H__g}, etc. #575

Merged
merged 4 commits into from
Feb 16, 2018
Merged

\hyperlink{H__g}, etc. #575

merged 4 commits into from
Feb 16, 2018

Conversation

jamesray1
Copy link
Contributor

No description provided.

@jamesray1 jamesray1 changed the title \hyperlink{H__g} \hyperlink{H__g}, etc. Feb 8, 2018
@pirapira
Copy link
Member

pirapira commented Feb 8, 2018

Needs merge. Skipping this one.

@jamesray1
Copy link
Contributor Author

@fulldecent I don't know why you are are approving these changes and in other PRs with merge conflicts when there are still conflicts to be resolved.

@fulldecent
Copy link
Contributor

Sorry for the confusion. I am reviewing based on a manual review of the diffs.

You're right. Instead I should be looking at the whole thing.

@jamesray1
Copy link
Contributor Author

jamesray1 commented Feb 16, 2018

No worries, I forgive you, just keep an eye out for builds failing and merge conflicts in future.

@jamesray1
Copy link
Contributor Author

@pirapira this should be good to merge now.

Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pirapira pirapira merged commit b2ad4fa into ethereum:master Feb 16, 2018
@pirapira
Copy link
Member

@jamesray1 @fulldecent I will notice merge conflicts. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants