Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypertargets for Omega, block-reward-R-b, Gamma, Phi and Pi #476

Merged
merged 7 commits into from
Feb 2, 2018

Conversation

jamesray1
Copy link
Contributor

No description provided.

Paper.tex Outdated
@@ -1107,14 +1107,14 @@ \subsection{Reward Application}
R & \equiv & (1 + \frac{1}{8} (U_i - {B_H}_i)) R_b
\end{eqnarray}

If there are collisions of the beneficiary addresses between ommers and the block (i.e. two ommers with the same beneficiary address or an ommer with the same beneficiary address as the present block), additions are applied cumulatively.
If there are collisions of the beneficiary addresses between ommers and the block (i.e. two ommers with the same beneficiary address or an ommer with the same beneficiary address as the present block), additions are applied cumulatively.\hypertarget{block-reward-R-b}{block-reward-R-b}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the target on the next equation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replied to the same question in another PR.

Paper.tex Outdated
@@ -1124,7 +1124,7 @@ \subsection{State \& Nonce Validation}\label{sec:statenoncevalidation}
\end{cases}
\end{equation}

Here, $\mathtt{\small TRIE}(L_S(\boldsymbol{\sigma}_i))$ means the hash of the root node of a trie of state $\boldsymbol{\sigma}_i$; it is assumed that implementations will store this in the state database, trivial and efficient since the trie is by nature an immutable data structure.
Here, $\mathtt{\small TRIE}(L_S(\boldsymbol{\sigma}_i))$ means the hash of the root node of a trie of state $\boldsymbol{\sigma}_i$; it is assumed that implementations will store this in the state database, trivial and efficient since the trie is by nature an immutable data structure.\hypertarget{Phi}{Phi}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the target in the next paragraph?

Paper.tex Outdated
@@ -1160,7 +1160,7 @@ \subsection{State \& Nonce Validation}\label{sec:statenoncevalidation}
We define $\mathbf{R}[n]_{s'}$ in a similar manner.
\begin{equation}
\mathbf{R}[n]_{s'} =
\Upsilon^{s}(\boldsymbol{\sigma}[n - 1], B_\mathbf{T}[n])
\Upsilon^{s}(\boldsymbol{\sigma}[n - 1], B_\mathbf{T}[n])\hypertarget{Pi}{Pi}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't the target in the next paragraph, where \Pi is defined?

@pirapira
Copy link
Member

Please use the newly defined \linkdest macro and move each target to the next line.

Paper.tex Outdated
@@ -1093,7 +1093,7 @@ \subsection{Transaction Validation}

\subsection{Reward Application}

The application of rewards to a block involves raising the balance of the accounts of the beneficiary address of the block and each ommer by a certain amount. We raise the block's beneficiary account by $R_b$; for each ommer, we raise the block's beneficiary by an additional $\frac{1}{32}$ of the block reward and the beneficiary of the ommer gets rewarded depending on the block number. Formally we define the function $\Omega$:
The application of rewards to a block involves raising the balance of the accounts of the beneficiary address of the block and each ommer by a certain amount. We raise the block's beneficiary account by $R_b$; for each ommer, we raise the block's beneficiary by an additional $\frac{1}{32}$ of the block reward and the beneficiary of the ommer gets rewarded depending on the block number.\hypertarget{Omega}{Omega} Formally we define the function $\Omega$:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be \hypertarget{Omega}{}.

Paper.tex Outdated
@@ -1109,14 +1109,14 @@ \subsection{Reward Application}

If there are collisions of the beneficiary addresses between ommers and the block (i.e. two ommers with the same beneficiary address or an ommer with the same beneficiary address as the present block), additions are applied cumulatively.

We define the block reward as 3 Ether:
\hypertarget{block-reward-R-b}{block-reward-R-b}We define the block reward as 3 Ether:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the second argument should be empty.

Paper.tex Outdated
\begin{equation}
\text{Let} \quad R_b = 3 \times 10^{18}
\end{equation}

\subsection{State \& Nonce Validation}\label{sec:statenoncevalidation}

We may now define the function, $\Gamma$, that maps a block $B$ to its initiation state:
\hypertarget{Gamma}{Gamma}We may now define the function, $\Gamma$, that maps a block $B$ to its initiation state:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, the second argument should be empty.

Paper.tex Outdated
@@ -1126,7 +1126,7 @@ \subsection{State \& Nonce Validation}\label{sec:statenoncevalidation}

Here, $\mathtt{\small TRIE}(L_S(\boldsymbol{\sigma}_i))$ means the hash of the root node of a trie of state $\boldsymbol{\sigma}_i$; it is assumed that implementations will store this in the state database, trivial and efficient since the trie is by nature an immutable data structure.

And finally define $\Phi$, the block transition function, which maps an incomplete block $B$ to a complete block $B'$:
\hypertarget{Phi}{Phi}And finally define $\Phi$, the block transition function, which maps an incomplete block $B$ to a complete block $B'$:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too.

Paper.tex Outdated
@@ -1163,7 +1163,7 @@ \subsection{State \& Nonce Validation}\label{sec:statenoncevalidation}
\Upsilon^{s}(\boldsymbol{\sigma}[n - 1], B_\mathbf{T}[n])
\end{equation}

Finally, we define $\Pi$ as the new state given the block reward function $\Omega$ applied to the final transaction's resultant state, $\ell(\boldsymbol{\sigma})$:
\hypertarget{Pi}{Pi}Finally, we define $\Pi$ as the new state given the block reward function $\Omega$ applied to the final transaction's resultant state, $\ell(\boldsymbol{\sigma})$:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here, too.

Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pirapira pirapira merged commit a015408 into ethereum:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants