Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings about async providers. #2845

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Remove warnings about async providers. #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/internals.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ exposed by the web3 object and the backend or node that web3 is connecting to.
* **Middlewares** provide hooks for monitoring and modifying requests and
responses to and from the provider. These can be *global* operating on all
providers or specific to one provider.
* **Managers** provide thread safety and primatives to allow for asynchronous usage of web3.
* **Managers** provide thread safety and primitives to allow for asynchronous usage of web3.

Here are some common things you might want to do with these APIs.

Expand Down
3 changes: 0 additions & 3 deletions docs/providers.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,6 @@ explicitly.
AsyncHTTPProvider
~~~~~~~~~~~~~~~~~

.. warning:: This provider is unstable and there are still gaps in
functionality. However, it is being actively developed.

.. py:class:: web3.providers.async_rpc.AsyncHTTPProvider(endpoint_uri[, request_kwargs])

This provider handles interactions with an HTTP or HTTPS based JSON-RPC server asynchronously.
Expand Down
1 change: 1 addition & 0 deletions newsfragments/2845.breaking.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove python warning and doc notes related to unstable async providers.
7 changes: 0 additions & 7 deletions web3/providers/async_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
Tuple,
cast,
)
import warnings

from eth_utils import (
to_bytes,
Expand Down Expand Up @@ -47,12 +46,6 @@ class AsyncBaseProvider:
global_ccip_read_enabled: bool = True
ccip_read_max_redirects: int = 4

def __init__(self) -> None:
warnings.warn(
"Async providers are still being developed and refined. "
"Expect breaking changes in minor releases."
)

@property
def middlewares(self) -> Tuple[AsyncMiddleware, ...]:
return self._middlewares
Expand Down