allow eth.filter to return appropriate sync/async filter types #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
reviewed
Sep 12, 2022
There was a problem hiding this comment.
Module has a property called is_async already. I think we could use that to differentiate instead of adding another is_async property on Method.
Also, I haven't tested this, but it looks like you could also combine the filter_wrapper with async_filter_wrapper if you wanted to. That's more of a stylistic thing though :) Otherwise, this looks good!
kclowes
reviewed
Sep 14, 2022
web3/_utils/method_formatters.py
Outdated
| LogFilter, | ||
| ]: | ||
|
|
||
| if type(module).__name__ == "Eth": |
There was a problem hiding this comment.
Sorry if this is just a wip and you don't want feedback, but could you check for module.is_async here?
There was a problem hiding this comment.
No problem - feedback always welcome, especially if I've asked for review. Will try it.
There was a problem hiding this comment.
Ok, updated, ready for re-review.
pacrob
force-pushed
the
method-class-async-flag
branch
2 times, most recently
from
3cf4b51 to
c77aa42
Compare
pacrob
force-pushed
the
asyncify-filters
branch
from
6b78d6c to
1266958
Compare
pacrob
force-pushed
the
method-class-async-flag
branch
from
c77aa42 to
2a21a0f
Compare
pacrob
force-pushed
the
method-class-async-flag
branch
from
2a21a0f to
61b52b6
Compare
pacrob
changed the title
pacrob
pushed a commit
that referenced
this pull request
Oct 7, 2022
* update method_formatters.py to select the appropriate sync/async filter type
pacrob
pushed a commit
that referenced
this pull request
Oct 24, 2022
* update method_formatters.py to select the appropriate sync/async filter type
pacrob
pushed a commit
that referenced
this pull request
Nov 21, 2022
* update method_formatters.py to select the appropriate sync/async filter type
pacrob
pushed a commit
that referenced
this pull request
Dec 2, 2022
* update method_formatters.py to select the appropriate sync/async filter type
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Dec 8, 2022
…eum#2645) * update method_formatters.py to select the appropriate sync/async filter type
pacrob
pushed a commit
that referenced
this pull request
Dec 19, 2022
* update method_formatters.py to select the appropriate sync/async filter type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to AsyncEth.filter were returning sync filter types
How was it fixed?
Updated associated plumbing, added testing
Cute Animal Picture