fix: Fixing syntax within EventScanner's scan_chunk method #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xRadiant
commented
May 26, 2022
| @@ -991,8 +991,12 @@ The script can be run with: ``python ./eventscanner.py <your JSON-RPC API URL>`` | |||
| # Get UTC time when this event happened (block mined timestamp) | |||
| # from our in-memory cache | |||
| block_when = get_block_when(block_number) | |||
|
|
|||
| logger.debug(f"Processing event {evt["event"]}, block: {evt["blockNumber"]} count: {evt["blockNumber"]}") | |||
There was a problem hiding this comment.
I also noticed that count and block both refer to evt["blockNumber"]. I'm not yet sure if this was intentional. If this is not intended, we can address this in the same pull request.
There was a problem hiding this comment.
I don't think that was intentional, please feel free to update! Thanks!
|
This got fixed in #2504. Thanks for the PR @0xRadiant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2486
How was it fixed?
Assigning the event, block number, and count to their own variables and pass them in to the logger.debug message.