Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ens request #2319

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Feature/ens request #2319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
979d928
fixed ens contract function called twice
dbfreem Jan 25, 2022
dcc5e12
newsfragment
dbfreem Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ens/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def resolve(self, name: str, get: str = 'addr') -> Optional[Union[ChecksumAddres
address = lookup_function(namehash).call()
if is_none_or_zero_address(address):
return None
return lookup_function(namehash).call()
return address
else:
return None

Expand Down
1 change: 1 addition & 0 deletions newsfragments/2318.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
In ENS the contract function to resolve an ENS address was being called twice in error. One of those calls was removed.