-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eth_feeHistory RPC endpoint #2094
Conversation
Hi! Please let me know if there is any feedback to the implementation so far. I'm just roughly following the implementations of similar RPC methods, but I'm not sure whether the tests are written properly. Thanks all! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mike6649! This looks like what we were going for! I added some nitpicky comments around the use of apply_list_to_array_formatter
vs. apply_formatter_to_array
that I'm curious to get your feedback on, but looks good other than that!
Also if you don't mind adding a newsfragment, that would be helpful. If you don't get to it, one of the maintainers can before merge. Thanks again!
Hi @kclowes , I made the suggested changes above and added a newsfragment. Let me know if there is anything else! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @mike6649! I'll get it merged soon!
What was wrong?
Post-london RPC endpoint
eth_feeHistory
is not currently supported. This PR adds support for it withfee_history
in the eth module.Related to Issue #2038
How was it fixed?
Following the eth1.0-specs,
fee_history
function was added to the eth module.Todo:
Cute Animal Picture