Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark flaky geth test as such #1834

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Mark flaky geth test as such #1834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newsfragments/1834.misc.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Mark Geth's replaceTransaction_already_mined test as flaky
8 changes: 8 additions & 0 deletions tests/integration/go_ethereum/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
from concurrent.futures._base import (
TimeoutError as FuturesTimeoutError,
)
import pytest

from web3._utils.module_testing import ( # noqa: F401
Expand All @@ -21,6 +24,11 @@ def test_eth_submitHashrate(self, web3):
# https://github.com/ethereum/go-ethereum/commit/51db5975cc5fb88db6a0dba1826b534fd4df29d7
super().test_eth_submitHashrate(web3)

@pytest.mark.xfail(
strict=False,
raises=FuturesTimeoutError,
reason='Sometimes a TimeoutError is hit when waiting for the txn to be mined',
)
def test_eth_replaceTransaction_already_mined(self, web3, unlocked_account_dual_type):
web3.geth.miner.start()
super().test_eth_replaceTransaction_already_mined(web3, unlocked_account_dual_type)
Expand Down