Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity modules to snake_case #1808

Closed
wants to merge 2 commits into from
Closed

Parity modules to snake_case #1808

wants to merge 2 commits into from

Conversation

ticekev
Copy link

@ticekev ticekev commented Dec 12, 2020

First open source contribution. Learning the lay of the land

Parity class modules updated from camelCase to snake_case

Related to Issue #1429

Todo:

(
image
)

@kclowes
Copy link
Collaborator

kclowes commented Jan 8, 2021

Thanks for the contribution @ticekev! Unfortunately, we need to deprecate these methods before moving them over to snake case, so we'll need to follow the DeprecatedMethod pattern that is laid out in #1326. This PR should also build on #1602, so if you want, once that's merged in (should be in the next couple days), then we can switch these to snake case.

@kclowes
Copy link
Collaborator

kclowes commented Jan 20, 2021

@ticekev #1602 has been merged in, so if you're still interested in finishing that up, you can rebase this branch on top of master and use the DeprecatedMethod pattern. PR #1828 is a good, recent example to follow. Let me know if you have questions, or feel free to close this PR if you're not interested in working on it. I'll pick it up when I get a chance unless you get there first. Thanks!

@kclowes
Copy link
Collaborator

kclowes commented Apr 23, 2021

Thanks for the work @ticekev! @tmckenzie51 has taken over this task

@kclowes kclowes closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants