[WIP] Eth to method #1568
[WIP] Eth to method #1568
Conversation
kclowes
force-pushed
the
eth-to-method
branch
5 times, most recently
from
e03f282 to
07b838d
Compare
kclowes
force-pushed
the
eth-to-method
branch
from
07b838d to
dfa1e4b
Compare
breaks sign and send raw middleware tests
| @@ -47,7 +47,7 @@ def get_linked_deployments(deployments: Dict[str, Any]) -> Dict[str, Any]: | |||
|
|
|||
|
|
|||
| def validate_linked_references( | |||
| link_deps: Tuple[Tuple[int, bytes], ...], bytecode: HexBytes | |||
| link_deps: Tuple[Tuple[int, bytes], ...], bytecode: HexStr | |||
There was a problem hiding this comment.
@njgheorghita I am not sure why I had to make this change to appease the linter, but do you see any problems with it?
There was a problem hiding this comment.
Hmm, I can't tell either off the top of my head, but this change doesn't seem problematic to me. 👍
There was a problem hiding this comment.
Yikes! good to see this happening. PR looks like it is going to be hard to review. Maybe consider doing this in smaller units and convert one or just a few methods at a time to cut down on the diff size? Ignore me if there is something about that approach that makes it non-viable.
| @@ -73,7 +73,7 @@ | |||
| "eth-account>=0.5.2,<0.6.0", | |||
| "eth-hash[pycryptodome]>=0.2.0,<1.0.0", | |||
| "eth-typing>=2.0.0,<3.0.0", | |||
| "eth-utils>=1.9.3,<2.0.0", | |||
| "eth-utils==1.9.3", | |||
There was a problem hiding this comment.
This will cause problems elsewhere if it remains. For example Trinity, installs Web3.py and I know that trinity requires a later version of eth-utils
There was a problem hiding this comment.
That's a bummer. eth-utils 1.9.4 breaks web3's linting so will probably have to update that before this can be shipped
| @@ -152,10 +155,23 @@ def validate_abi_value(abi_type: TypeStr, value: Any) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def is_ordinary_string(value: Any) -> bool: | |||
| return (is_string(value) and not is_bytes(value) and not | |||
There was a problem hiding this comment.
I think that the is_string check and the is_bytes check are mutually exclusive so you should be able to drop the is_bytes check.
| @@ -152,10 +155,23 @@ def validate_abi_value(abi_type: TypeStr, value: Any) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def is_ordinary_string(value: Any) -> bool: | |||
There was a problem hiding this comment.
Maybe this would be more accurately named: is_non_address_string or something with the same intent?
|
That is a good idea. I'll work on splitting it into a few PRs! |
|
This got split into a bunch of PRs referenced above, but they've all been merged. Closing! |
What was wrong?
Related to Issue #
How was it fixed?
Todo:
Cute Animal Picture