Event process receipt #1366
Merged
Event process receipt #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
event-process-receipt
branch
from
ac0358a to
ca3a649
Compare
kclowes
force-pushed
the
event-process-receipt
branch
3 times, most recently
from
b1328d3 to
76e8f0c
Compare
Merged
pipermerriam
approved these changes
Jun 14, 2019
| "6fbb0e16a6d89c6804c461f65a1b40bb15816040518082815260200191505060405180910390a17" | ||
| "f56d2ef3c5228bf5d88573621e325a4672ab50e033749a601e4f4a5e1dce905d481604051808281" | ||
| "5260200191505060405180910390a1505600a165627a7a72305820ff79430a04cf654d7b46edc52" | ||
| "9ccaa5d7f77607f54bb58210be0c48455292c810029" |
There was a problem hiding this comment.
@njgheorghita and @kclowes probably already said this a few times but I think it makes sense to start dog-fooding the ethpm APIs and to package these up as ethpm packages to get these blobs of bytecode out of the tests.
kclowes
force-pushed
the
event-process-receipt
branch
from
615cbad to
2f416ac
Compare
kclowes
force-pushed
the
event-process-receipt
branch
2 times, most recently
from
00afc6f to
d81403d
Compare
|
@pipermerriam I just have a couple things that could use your 👀 when you get a chance:
Thanks! |
pipermerriam
approved these changes
Jul 11, 2019
- Add documentation for event log error flags - Change ValueError to custom error, - Split tests to handle different MismatchedABI cases, and split error flag tests out - Make the warn behavior the fallback
kclowes
force-pushed
the
event-process-receipt
branch
from
5aa1f22 to
99e0317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There was no way to ignore or discard event log errors if they came up during processing.
Related to Issue #1351. Also fixes #1330
How was it fixed?
Added a new optional error kwarg to
processReceiptto handle discarding and ignoring errors.I'll rebase before merging.
Cute Animal Picture