mark deprecated sha3 method as static #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As all the sha3 tests were removed in v5, I wasn't sure I should add a test for this. |
|
Can we get a test added for this (something that fails if the decorator is missing) |
|
I'll fix the lint error when the tests pass. |
nbt-rezaem
force-pushed
the
master
branch
4 times, most recently
from
2b803bd to
b69cc23
Compare
|
Is the added test good enough? |
kclowes
approved these changes
May 9, 2019
|
Thanks for improving the test. Please merge at your convenience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #1349
How was it fixed?
added @staticmethod annotation to the method
Cute Animal Picture