Remove all remaining guess_tld kwargs #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
remove-guess-tld
branch
2 times, most recently
from
4415792
to
cb0e2cd
Compare
|
@kclowes - Seems like something strange is happening. Now all the geth1.7.1 tests are passing and only some of the 1.8.22 tests are failing |
|
So weird. I just rebuilt and it looks like we're back in business! |
kclowes
approved these changes
Apr 5, 2019
.circleci/config.yml
Outdated
| @@ -81,8 +81,8 @@ geth_steps: &geth_steps | |||
| export GOROOT=/usr/local/go | |||
| export GETH_BINARY="$HOME/.py-geth/geth-$GETH_VERSION/bin/geth" | |||
| if [ ! -e "$GETH_BINARY" ]; then | |||
| curl -O https://storage.googleapis.com/golang/go1.12.1.linux-amd64.tar.gz | |||
| tar xvf go1.12.1.linux-amd64.tar.gz | |||
| curl -O https://storage.googleapis.com/golang/go1.9.1.linux-amd64.tar.gz | |||
There was a problem hiding this comment.
Wait... does this PR pass the test suite with go1.12? If it does, we might as well keep it there. If not, 1.9 is good
njgheorghita
force-pushed
the
remove-guess-tld
branch
from
cb0e2cd
to
ac80a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There were some lingering
guess_tldkwargs that should have been removed in #1205Cute Animal Picture