Add error if no Infura key is found #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
commented
Mar 20, 2019
kclowes
force-pushed
the
throw-error-infura
branch
2 times, most recently
from
252cd16 to
9ae9610
Compare
pipermerriam
approved these changes
Mar 25, 2019
kclowes
force-pushed
the
throw-error-infura
branch
from
eadc1f7 to
e83e0ab
Compare
carver
reviewed
Mar 27, 2019
| @@ -1,3 +1,4 @@ | |||
| import os | |||
There was a problem hiding this comment.
Is this cruft from some local changes? I don't see how it's used.
Edit: oops, this was sitting in a pending review, unpublished. Super minor, anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Infura will stop supporting API calls without a key on 3/27.
Related to Issue #1246
How was it fixed?
Now an error is thrown when connecting to Infura if there is no API key found.
Cute Animal Picture