Add manifest and input arg validation to pm.release_package() #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
approved these changes
Feb 7, 2019
web3/pm.py
Outdated
| if ( | ||
| not is_ipfs_uri(manifest_uri) and | ||
| not is_valid_content_addressed_github_uri(manifest_uri) | ||
| ): |
There was a problem hiding this comment.
We've avoided multi-line if statements via the following convention.
is_something = (
<multi-line-statement
)
if is_something:
...
web3/pm.py
Outdated
| not is_ipfs_uri(manifest_uri) and | ||
| not is_valid_content_addressed_github_uri(manifest_uri) | ||
| ): | ||
| raise PMError( |
There was a problem hiding this comment.
Seems like this should be some sort of ValidationError type error. The base library error is normally not used directly, but rather designed to be a way for someone to catch any library error from py-ethpm
njgheorghita
force-pushed
the
pm-api-validation
branch
2 times, most recently
from
3805420 to
9a89f71
Compare
njgheorghita
force-pushed
the
pm-api-validation
branch
from
9a89f71 to
69dffd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
More validation in
pm.release_package()would be useful to prevent mix-ups between on-registry data and data actually in the manifest, and prevent pushing invalid manifest to your registryHow was it fixed?
pm.release_package()that the manifest uri is a valid content-addressed (IPFS/github) URI.package_nameandversionmatch what's stored in the manifestCute Animal Picture