Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build #1080

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix docs build #1080

merged 1 commit into from
Oct 2, 2018

Conversation

dylanjw
Copy link
Contributor

@dylanjw dylanjw commented Oct 2, 2018

What was wrong?

Related to Issue #1075

How was it fixed?

Added requirements-docs.txt with .[docs]. I dont know if that will work with RTD, and Im not sure how to test.

Cute Animal Picture

image

@pipermerriam
Copy link
Member

pipermerriam commented Oct 2, 2018

We can build individual branches on RTD, you should make a branch in the core web3 repo and enable the build in read-the-docs. Send me your RTD username and I'll add you as a maintainer. Then you can push directly to that branch (not in your fork but in the ethereum/web3.py repository) and RTD will build that branch.

@dylanjw
Copy link
Contributor Author

dylanjw commented Oct 2, 2018

RTD build works with .[doc]
https://readthedocs.org/projects/web3py/builds/7880473/

@dylanjw dylanjw merged commit d3d1dd1 into ethereum:master Oct 2, 2018
@carver carver mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants