Organize eth module as separate files #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
organize-eth-module-as-separate-files
branch
from
2ee9322 to
49cf737
Compare
fselmo
force-pushed
the
organize-eth-module-as-separate-files
branch
from
ef70b1b to
11b9457
Compare
fselmo
commented
Dec 16, 2022
| @@ -115,7 +115,7 @@ def __init__( | |||
| validate_w3_instance(w3) | |||
|
|
|||
| self.w3 = w3 | |||
| self.w3.eth.defaultContractFactory = cast(Type[Contract], LinkableContract) | |||
| self.w3.eth._default_contract_factory = cast(Type[Contract], LinkableContract) | |||
There was a problem hiding this comment.
Was this ever meant to be a public property? 🤔
I don't mind putting this back, but this made a bit more sense. We don't have documentation on this afaik.
There was a problem hiding this comment.
I don't see any docs either, so I think this is good.
fselmo
force-pushed
the
organize-eth-module-as-separate-files
branch
from
11b9457 to
dc1b92a
Compare
fselmo
force-pushed
the
organize-eth-module-as-separate-files
branch
2 times, most recently
from
e8118fe to
cf175bf
Compare
fselmo
force-pushed
the
organize-eth-module-as-separate-files
branch
from
cf175bf to
f177ec9
Compare
kclowes
approved these changes
Jan 5, 2023
| @@ -115,7 +115,7 @@ def __init__( | |||
| validate_w3_instance(w3) | |||
|
|
|||
| self.w3 = w3 | |||
| self.w3.eth.defaultContractFactory = cast(Type[Contract], LinkableContract) | |||
| self.w3.eth._default_contract_factory = cast(Type[Contract], LinkableContract) | |||
There was a problem hiding this comment.
I don't see any docs either, so I think this is good.
- Reorganize and add comments to ``AsyncEth`` for filter-related, eth-underscored calls.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
ethmodule into separate filesethmethodsTodo:
Cute Animal Picture