Skip to content

Commit

Permalink
Changes from comments on PR #2753
Browse files Browse the repository at this point in the history
- Reorganize and add comments to ``AsyncEth`` for filter-related, eth-underscored calls.
  • Loading branch information
fselmo committed Jan 5, 2023
1 parent be353e5 commit 15d185b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
2 changes: 2 additions & 0 deletions web3/eth/async_eth.py
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,8 @@ async def get_storage_at(
mungers=[BaseEth.filter_munger],
)

# eth_getFilterChanges, eth_getFilterLogs, eth_uninstallFilter

_get_filter_changes: Method[
Callable[[HexStr], Awaitable[List[LogReceipt]]]
] = Method(RPC.eth_getFilterChanges, mungers=[default_root_munger])
Expand Down
14 changes: 6 additions & 8 deletions web3/eth/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ def sign_munger(
mungers=[BaseEth.filter_munger],
)

# eth_getFilterChanges, eth_getFilterLogs
# eth_getFilterChanges, eth_getFilterLogs, eth_uninstallFilter

get_filter_changes: Method[Callable[[HexStr], List[LogReceipt]]] = Method(
RPC.eth_getFilterChanges, mungers=[default_root_munger]
Expand All @@ -609,6 +609,11 @@ def sign_munger(
RPC.eth_getFilterLogs, mungers=[default_root_munger]
)

uninstall_filter: Method[Callable[[HexStr], bool]] = Method(
RPC.eth_uninstallFilter,
mungers=[default_root_munger],
)

# eth_submitHashrate

submit_hashrate: Method[Callable[[int, _Hash32], bool]] = Method(
Expand All @@ -627,10 +632,3 @@ def sign_munger(
RPC.eth_submitWork,
mungers=[default_root_munger],
)

# eth_uninstallFilter

uninstall_filter: Method[Callable[[HexStr], bool]] = Method(
RPC.eth_uninstallFilter,
mungers=[default_root_munger],
)

0 comments on commit 15d185b

Please sign in to comment.