Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Update geth fixture to use geth v1.10.17 #2453

Merged
merged 3 commits into from
May 3, 2022

Conversation

fselmo
Copy link
Collaborator

@fselmo fselmo commented May 2, 2022

What was wrong?

py-geth 3.8.0 was released with support for geth v1.10.17. We should update our test fixture to use the latest geth version.

How was it fixed?

  • Update test fixture to use geth version 1.10.17 and update py-geth version to 3.8.0
  • Update go version used in circleci geth steps to 1.18.1
  • Add xfail strict=False to eth estimate_gas tests and unmined transaction receipt tests

Todo:

Cute Animal Picture

Monito del Monte:

Put a link to a cute animal picture inside the parenthesis-->

@fselmo fselmo force-pushed the geth-1.10.17-fixture-update branch from 35f95ab to db127c8 Compare May 2, 2022 15:57
@fselmo fselmo force-pushed the geth-1.10.17-fixture-update branch 2 times, most recently from 89bb523 to 5d8dde7 Compare May 2, 2022 18:06
@fselmo fselmo changed the title Update geth fixture to use geth v1.10.17 [v5] Update geth fixture to use geth v1.10.17 May 2, 2022
@fselmo fselmo force-pushed the geth-1.10.17-fixture-update branch 2 times, most recently from cdf1e1d to ecfc48b Compare May 2, 2022 18:20
@fselmo fselmo requested a review from kclowes May 2, 2022 18:28
@fselmo fselmo force-pushed the geth-1.10.17-fixture-update branch 2 times, most recently from a5d46b3 to 56ecbf1 Compare May 2, 2022 18:46
- Add more flaky tests to the list that have timeout issues.
@fselmo fselmo force-pushed the geth-1.10.17-fixture-update branch from 56ecbf1 to 41f078a Compare May 2, 2022 20:42
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 !

@fselmo fselmo merged commit ea74b7a into ethereum:v5 May 3, 2022
@fselmo fselmo deleted the geth-1.10.17-fixture-update branch June 8, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants