Skip to content

Commit

Permalink
Add xfail strict=False to eth estimate_gas tests.
Browse files Browse the repository at this point in the history
- Add more flaky tests to the list that have timeout issues.
  • Loading branch information
fselmo committed May 3, 2022
1 parent 6d540d5 commit ea74b7a
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 1 deletion.
2 changes: 1 addition & 1 deletion newsfragments/2453.misc.rst
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Update geth fixture to use geth version ``v1.10.17``
Update geth fixture to use geth version ``v1.10.17``. Add pytest xfail with strict=False for flaky eth estimage_gas tests.
55 changes: 55 additions & 0 deletions tests/integration/go_ethereum/common.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import pytest
from typing import (
TYPE_CHECKING,
)

from eth_typing import (
ChecksumAddress,
)

from web3._utils.module_testing import ( # noqa: F401
AsyncEthModuleTest,
Expand All @@ -12,6 +19,14 @@
VersionModuleTest,
Web3ModuleTest,
)
from web3.types import (
BlockData,
)

if TYPE_CHECKING:
from web3 import ( # noqa: F401
Web3,
)


class GoEthereumTest(Web3ModuleTest):
Expand Down Expand Up @@ -40,6 +55,46 @@ def test_eth_protocol_version(self, web3):
def test_eth_protocolVersion(self, web3):
super().test_eth_protocolVersion(web3)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_estimate_gas(
self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress
) -> None:
super().test_eth_estimate_gas(web3, unlocked_account_dual_type)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_estimateGas_deprecated(
self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress
) -> None:
super().test_eth_estimateGas_deprecated(web3, unlocked_account_dual_type)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_estimate_gas_with_block(
self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress
) -> None:
super().test_eth_estimate_gas_with_block(web3, unlocked_account_dual_type)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_get_transaction_receipt_unmined(
self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress
) -> None:
super().test_eth_get_transaction_receipt_unmined(web3, unlocked_account_dual_type)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_wait_for_transaction_receipt_unmined(
self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress
) -> None:
super().test_eth_wait_for_transaction_receipt_unmined(web3, unlocked_account_dual_type)

@pytest.mark.xfail(reason='Inconsistently creating timeout issues.', strict=False)
def test_eth_get_raw_transaction_by_block(
self, web3: "Web3",
unlocked_account_dual_type: ChecksumAddress,
block_with_txn: BlockData,
) -> None:
super().test_eth_get_raw_transaction_by_block(
web3, unlocked_account_dual_type, block_with_txn
)


class GoEthereumVersionModuleTest(VersionModuleTest):
@pytest.mark.xfail(reason='eth_protocolVersion was removed in Geth 1.10.0')
Expand Down

0 comments on commit ea74b7a

Please sign in to comment.