Asyncify eth.get_transaction_receipt and eth.wait_for_transaction_receipt #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacrob
force-pushed
the
asyncify_eth.wait_for_transaction_receipt
branch
3 times, most recently
from
dcc26d0 to
54abdde
Compare
pacrob
force-pushed
the
asyncify_eth.wait_for_transaction_receipt
branch
from
54abdde to
4a311ec
Compare
pacrob
changed the title
kclowes
approved these changes
Dec 17, 2021
| mungers=[default_root_munger] | ||
| ) | ||
|
|
||
| # _get_transaction_receipt_awaitable: Method[Callable[[_Hash32], |
There was a problem hiding this comment.
Yup, thanks for catching
kclowes
reviewed
Dec 17, 2021
| tx_receipt = None | ||
| if tx_receipt is not None: | ||
| break | ||
| _timeout.sleep(poll_latency) |
There was a problem hiding this comment.
Sorry to pop up again after approving this, but I think we want to be able to await this so it's not blocking. I think the most straightforward route is to get rid of the timeout context and use await asyncio.sleep here. If you want to see if it makes a difference at all, you could add it to our benchmarking suite and see what happens :)
There was a problem hiding this comment.
Makes sense. _timeout.sleep replaced with await asyncio.sleep
pacrob
force-pushed
the
asyncify_eth.wait_for_transaction_receipt
branch
from
be2c88f to
8eebc82
Compare
pacrob
force-pushed
the
asyncify_eth.wait_for_transaction_receipt
branch
from
8eebc82 to
5c7863e
Compare
pacrob
pushed a commit
to pacrob/web3.py
that referenced
this pull request
Dec 17, 2021
pacrob
pushed a commit
that referenced
this pull request
Dec 21, 2021
- cleaned up async wait_for_transaction_receipt() - added tests for sync wait_for_transaction_receipt() - updated tests for async wait_for_transaction_receipt()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Added async
eth.get_transaction_receiptandeth.wait_for_transaction_receiptRelated to Issue #1413
Closes Issue #2129
How was it fixed?
Todo:
Cute Animal Picture