Async HTTP Provider #1978
Async HTTP Provider #1978
Conversation
|
I still have some typing to work out, but would love to get some feedback on general shape! This is the MVP implementation with absolutely nothing fancy - no middleware, no session caching, etc. I'll put those features in separate PRs! |
kclowes
force-pushed
the
async-base-provider
branch
from
3208e26 to
5a76a89
Compare
|
|
||
| @pytest.mark.asyncio | ||
| async def test_isConnected(self, async_w3_http: "Web3") -> None: | ||
| assert await async_w3_http.isConnected() is True |
There was a problem hiding this comment.
I'm getting a mypy error on this line:
Incompatible types in "await" (actual type "bool", expected type "Awaitable[Any]")
And I'm not sure how to fix it. I think it should be a bool, but I'm not sure where/why it thinks it should be an Awaitable[Any] 🤔
There was a problem hiding this comment.
I think maybe what this line is actually doing is assert await (async_w3_http.isConnected() is True)
The await may not be applied before the is True causing this to be a boolean being fed to an await statement?
There was a problem hiding this comment.
Maybe because of the decorator, I guess? Try adding @overload
kclowes
force-pushed
the
async-base-provider
branch
2 times, most recently
from
cd2c442 to
3b3f51c
Compare
|
|
||
| @pytest.mark.asyncio | ||
| async def test_isConnected(self, async_w3_http: "Web3") -> None: | ||
| assert await async_w3_http.isConnected() is True |
There was a problem hiding this comment.
I think maybe what this line is actually doing is assert await (async_w3_http.isConnected() is True)
The await may not be applied before the is True causing this to be a boolean being fed to an await statement?
|
|
||
| @property | ||
| async def gas_price(self) -> Wei: | ||
| # types ignored b/c mypy conflict with BlockingEth properties |
There was a problem hiding this comment.
Yeah, this is unfortunate and would be nice to resolve... but I'm not sure what to suggest.
kclowes
force-pushed
the
async-base-provider
branch
from
3b3f51c to
9cee725
Compare
kclowes
force-pushed
the
async-base-provider
branch
from
f9db8fe to
1a32209
Compare
What was wrong?
Adds a bare bones async http provider. No middleware yet, and no session caching.
Related to Issue #1413
Todo:
Cute Animal Picture