Parity to method class #1602
Merged
Parity to method class #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
parity-to-method-class
branch
from
a458ac1 to
9a970f8
Compare
kclowes
force-pushed
the
parity-to-method-class
branch
3 times, most recently
from
c93c650 to
1fdec7f
Compare
kclowes
commented
Apr 17, 2020
kclowes
force-pushed
the
parity-to-method-class
branch
from
2e4abac to
78af94b
Compare
kclowes
force-pushed
the
parity-to-method-class
branch
from
fbadf4d to
af46526
Compare
kclowes
requested review from
pipermerriam and
wolovim
and removed request for
pipermerriam
wolovim
force-pushed
the
parity-to-method-class
branch
from
af46526 to
211b04d
Compare
wolovim
reviewed
Jul 22, 2020
There was a problem hiding this comment.
This may sit for a while longer, but just caught it up with master. Looks good generally and tests are happy, but I don't grok all, so couple of requests for clarification below.
Separate from the intention of this PR, we might be due for a discussion on Parity vs. OpenEthereum support (and maybe other nodes?). Lots of Parity nodes still in use, so obviously we won't chuck that out anytime soon. This topic also comes to mind though after recent All Core Devs conversations about increasing client diversity... Probably worth its own issue.
kclowes
force-pushed
the
parity-to-method-class
branch
from
cda3b17 to
fe8e2b8
Compare
kclowes
force-pushed
the
parity-to-method-class
branch
3 times, most recently
from
b6356d3 to
9bcdc02
Compare
kclowes
force-pushed
the
parity-to-method-class
branch
from
9bcdc02 to
c8bdbd4
Compare
|
@marcgarreau I think this is (finally) ready to go! |
kclowes
force-pushed
the
parity-to-method-class
branch
2 times, most recently
from
0ebfe76 to
864e13c
Compare
wolovim
approved these changes
Jan 15, 2021
kclowes
force-pushed
the
parity-to-method-class
branch
from
864e13c to
cf57aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The Parity class needed to move over to use the
Methodclass andModuleV2class.How was it fixed?
Started using
MethodandModuleV2Todo:
Cute Animal Picture