Document update for v5 #1527
Merged
Document update for v5 #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ashish10677! This looks good! I noticed that the migration docs are wrong. |
|
@kclowes sorry for the mistake. I've updated the docs. Do I need to create a new merge request? |
|
@kclowes 1 lint test is failing. Can you tell me how to fix it? |
kclowes
approved these changes
Dec 2, 2019
…d error instead of None for RPC methods that don't find a transaction. Signed-off-by: ashish10677 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The docs weren't updated when we started returning a TransactionNotFound or BlockNotFound error instead of None for RPC methods that don't find a transaction.
Related to Issue #1522
How was it fixed?
Updated all the functions mentioned in https://web3py.readthedocs.io/en/stable/v5_migration.html#json-rpc-updates
Todo:
Cute Animal Picture