-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs to reflect methods that raise errors in v5 instead of returning None #1522
Comments
Hi. I want to try to contribute to this issue. Can you please assign it to me? |
Thanks @ashish10677! Let me know if you have questions! |
@kclowes I had a very silly doubt. In the documentation, these methods: https://web3py.readthedocs.io/en/stable/v5_migration.html#json-rpc-updates , only one of them has a return type of |
Yep, let's go ahead and include the return type for all of them. |
@kclowes I have raised a pull request. I am very new to open source contributions. Please guide me if there are any mistakes that I can fix. I will be happy to do it. |
@swixx Yes! Thanks! |
What was wrong?
The docs weren't updated when we started returning a
TransactionNotFound
orBlockNotFound
error instead ofNone
for RPC methods that don't find a transaction.How can it be fixed?
Docs need to be checked and updated for the following methods:
https://web3py.readthedocs.io/en/stable/v5_migration.html#json-rpc-updates
The text was updated successfully, but these errors were encountered: