Skip to content

Commit

Permalink
Refactor geth steps to pip install correct py-geth version
Browse files Browse the repository at this point in the history
- Make sure pip is up to date
- Use quotes for pip install with minimum version ``pip install --user "py-geth>={version}"`` (https://pip.pypa.io/en/stable/cli/pip_install/#examples)
  • Loading branch information
fselmo committed Mar 28, 2023
1 parent 7592e98 commit cd806cf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,14 @@ geth_steps: &geth_steps
- cache-{{ .Environment.CIRCLE_JOB }}-{{ checksum "setup.py" }}-{{ checksum "tox.ini" }}
- run:
name: install dependencies
command: pip install --user tox
command: |
pip install --upgrade pip
pip install --user tox
- run:
name: build geth if missing
command: |
mkdir -p $HOME/.ethash
pip install --user py-geth>=<< pipeline.parameters.pygeth_version >>
pip install --user "py-geth>=<< pipeline.parameters.pygeth_version >>"
export GOROOT=/usr/local/go
echo << pipeline.parameters.geth_version >>
export GETH_BINARY="$HOME/.py-geth/geth-<< pipeline.parameters.geth_version >>/bin/geth"
Expand Down
2 changes: 2 additions & 0 deletions newsfragments/2898.internal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Update ``geth_steps`` in CircleCI builds to pip install the proper version of ``py-geth``.gs

0 comments on commit cd806cf

Please sign in to comment.