Remove xfail for tests that pass

ethereum · Jul 8, 2019 · c1a5536 · c1a5536
1 parent 42c556a
commit c1a5536
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/tests/integration/go_ethereum/common.py b/tests/integration/go_ethereum/common.py
@@ -21,11 +21,9 @@ def test_eth_replaceTransaction(self, web3, unlocked_account):
         super().test_eth_replaceTransaction(web3, unlocked_account)
 
     def test_eth_replaceTransaction_incorrect_nonce(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_incorrect_nonce(web3, unlocked_account)
 
     def test_eth_replaceTransaction_gas_price_too_low(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_gas_price_too_low(web3, unlocked_account)
 
     @pytest.mark.xfail(reason='Needs ability to efficiently control mining')

diff --git a/tests/integration/go_ethereum/test_goethereum_ws.py b/tests/integration/go_ethereum/test_goethereum_ws.py
@@ -77,6 +77,6 @@ class TestMiscWebsocketTest(MiscWebsocketTest):
 
 
 class TestGoEthereumShhModuleTest(CommonGoEthereumShhModuleTest):
-    @pytest.mark.xfail(reason="async filter bug in geth ws version")
     def test_shh_async_filter(self, web3):
+        pytest.xfail("async filter bug in geth ws version")
         super().test_shh_async_filter(web3)
diff --git a/tests/integration/parity/common.py b/tests/integration/parity/common.py
@@ -41,37 +41,31 @@ def test_eth_uninstallFilter(self, web3):
         super().test_eth_uninstallFilter(web3)
 
     def test_eth_replaceTransaction(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction(web3, unlocked_account)
 
     @pytest.mark.xfail(reason='Parity is not setup to auto mine')
     def test_eth_replaceTransaction_already_mined(self, web3, unlocked_account):
         super().test_eth_replaceTransaction_already_mined(web3, unlocked_account)
 
     def test_eth_replaceTransaction_incorrect_nonce(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_incorrect_nonce(web3, unlocked_account)
 
     def test_eth_replaceTransaction_gas_price_too_low(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_gas_price_too_low(web3, unlocked_account)
 
     def test_eth_replaceTransaction_gas_price_defaulting_minimum(self, web3, unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_gas_price_defaulting_minimum(web3, unlocked_account)
 
     def test_eth_replaceTransaction_gas_price_defaulting_strategy_higher(self,
                                                                          web3,
                                                                          unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_gas_price_defaulting_strategy_higher(
             web3, unlocked_account
         )
 
     def test_eth_replaceTransaction_gas_price_defaulting_strategy_lower(self,
                                                                         web3,
                                                                         unlocked_account):
-        pytest.xfail('Needs ability to efficiently control mining')
         super().test_eth_replaceTransaction_gas_price_defaulting_strategy_lower(
             web3, unlocked_account
         )
@@ -190,12 +184,12 @@ class ParityTraceModuleTest(TraceModuleTest):
 
 
 class CommonParityShhModuleTest(ParityShhModuleTest):
-    @pytest.mark.xfail(reason="Skip until parity filter bug is resolved")
     def test_shh_sync_filter(self, web3):
         # https://github.com/paritytech/parity-ethereum/issues/10565
+        pytest.xfail("Skip until parity filter bug is resolved")
         super().test_shh_sync_filter(web3)
 
-    @pytest.mark.xfail(reason="Skip until parity filter bug is resolved")
     def test_shh_async_filter(self, web3):
         # https://github.com/paritytech/parity-ethereum/issues/10565
+        pytest.xfail("Skip until parity filter bug is resolved")
         super().test_shh_async_filter(web3)