Merge pull request #1532 from njgheorghita/ethpm-improve-error-msg

[ethPM] Improved duplicate contract types error message
ethereum · Dec 3, 2019 · 8ea04e1 · 8ea04e1
2 parents e42739b + 658af9c
commit 8ea04e1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ethpm/tools/builder.py b/ethpm/tools/builder.py
@@ -433,8 +433,9 @@ def normalize_compiler_output(compiler_output: Dict[str, Any]) -> Dict[str, Any]
     ]
     paths, names = zip(*paths_and_names)
     if len(names) != len(set(names)):
+        duplicates = set([name for name in names if names.count(name) > 1])
         raise ManifestBuildingError(
-            "Duplicate contract names were found in the compiler output."
+            f"Duplicate contract types: {duplicates} were found in the compiler output."
         )
     return {
         name: normalize_contract_type(compiler_output[path][name])

diff --git a/newsfragments/1532.misc.rst b/newsfragments/1532.misc.rst
@@ -0,0 +1 @@
+Improve error message in ethpm's builder.